-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Guns and Mosin Rework and Sawn PKA fix #1143
Conversation
RSI Diff Bot; head commit bb192da merging into 69a12c7 Resources/Textures/_NF/Objects/Weapons/Ammunition/svt40.rsi
Resources/Textures/_NF/Objects/Weapons/Guns/Pistols/Valentine.rsi
Resources/Textures/_NF/Objects/Weapons/Guns/Rifles/svt40.rsi
|
Yes, I know about the File with the Revolver ( I will fix it) and Spawner file (I will learn how to remove it) |
Im not sure what the problem is with the Sprites. They are just fine in-game for me |
…change the meta.json to the right one
Fix, the One for the gun, im going to need another set of eyes for this other error I'm getting, because I'm not seeing why it is saying that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most item descriptions have language mistakes in them. I've gone through and suggested changes for all of those which were directly apparent.
Your CL could be shortened into four entries, one for the mosin, one for the two new guns ("New guns: The SVT140 and Valentine pistol"), one for the two new grenades (see before) and one for the nugget recipe. I'd also reword this last one to not be roleplay-style: "Chicken nuggets now have a cooking recipe."
Lastly, and end-of-comment marker (-->
) has snuck in below your CL entries.
Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/snipers.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Objects/Weapons/Ammunition/explosives.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/pistols.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Objects/Weapons/Ammunition/explosives.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/pistols.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/snipers.yml
Outdated
Show resolved
Hide resolved
@TsjipTsjip @GreaseMonk , I think I made all the changes. |
It makes no sense to add guns and then also add a cooking recipe, in the same PR, so split them up please, you could even make 3, so people can decide to add guns and food, but not the grenade. Got some more points of concern here:
Please please make sure the guns are balanced, so it is ready for people to test and its not immediately overkill |
-If I would to split up them in others PR I can 100% guarantee that something on my visual studios will break and it will take even more time to fix. I don't recall Dirv talking to me about the PR at all.
I Tested the weapons to what I thought was fair. I suggest everytime I add a weapon or a event for the maintainers to test it |
"No NFSD won't get warcrime grenades" but then they're in a vendor? These are class 3 contraband, and should probably be on expeds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other minor things on the updated version. Nearly good tho.
Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/pistols.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/pistols.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/_NF/Entities/Objects/Weapons/Guns/Guns/snipers.yml
Outdated
Show resolved
Hide resolved
space-wizards/space-station-14#25444 Omit cleaner. |
Also your mosins made my build crash none stop when trying to use them now. (Build mod, not debug) |
you know more Info then it crashes would help, Espically since I don't have "Build" and the Video is showing us to use Release |
It crashes when a mosin is handed out of a vending machine on frontier i think |
I tested it on both vending machines that has it and spawn new ones. In and it isn't crashing or showing any errors for me. I put screen shots on the development chat |
I'm going to re-PR this at a later date. I however will not close until the new on is up. I will be putting the Mosin by itself, the SVT and Valentine together, and the Grenades In a different on. This will happen, After My Bluespace event is merge |
About the PR
adds the SVT40
add the Valentine
add the Space Cleaner grenade
add the M34 'Willie Pete' grenade (Kes request)
add chicken nugget recipe
Rework the Mosin to allow Melee now
Why / Balance
Well, there aren't a lot of End shift Legal weapons, this PR adds a point between The Mosin and the AK with the new SVT40 rifle also added another pistol to be put inside the loot pool for gunships (SVT could be in T3)
As of now, I have added them to the less lethal Vending machine, and Liberation. Until the Loot spawn.yml is approve in the Research Bunker PR
Technical details
Also, Clean up some of the Files for Texures and Weapons to be in there Respective parts
Media
Breaking changes
again just some File cleaning in the Weapons area
Changelog